-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): switch from fast-glob to tinyglobby #29141
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5848e0f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
3bfcc89
to
2668d97
Compare
Thanks @benmccann got some task failures to take a look |
Thanks @JamesHenry. When I run
|
@benmccann The issue is that you haven't added The repo doesn't (yet) use package manager workspaces, so your reference in the You can verify this with ❯ pnpm why tinyglobby х 1 24s
Legend: production dependency, optional only, dev only
@nx/nx-source /Users/james/Repos/open-source/nrwl/nx-alt
devDependencies:
nuxt 3.13.2
├─┬ @nuxt/devtools 1.4.2
│ └── tinyglobby 0.2.6
└── tinyglobby 0.2.6 Right now the only way tinyglobby gets into the workspace is via a direct and transitive dependency from the Therefore the fix is to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @benmccann, sorry I should have remembered this earlier:
Every time we make one of these kinds of PRs we should add a lint entry to prevent regressions:
Line 8 in 5d61191
"no-restricted-imports": [ |
(It would be easy for a member of the team not familiar with this effort to add fast-glob back in again)
FYI I made it a fix pre merge so it gets called out in the changelog |
(cherry picked from commit e3f8c81)
Current Behavior
17 dependencies: https://npmgraph.js.org/?q=fast-glob
Expected Behavior
2 dependencies: https://npmgraph.js.org/?q=tinyglobby
Related Issue(s)
es-tooling/ecosystem-cleanup#117